Merged
Conversation
…created via swapchain image objects.
… Make graphics contexts thread-local in the implemenetation, this still needs to be done on the agnostic side. Delete tons of device code. TODO: Allow Swapchain images to present and to resolve where the queue submit logic will live.
…ring, figure out how we're gonna cache descriptor sets.
…bably should? It worked when I used it last.
FiniteReality
force-pushed
the
feature/ecs-time-context-refactor
branch
from
9488d61 to
fc76b03
Compare
capnkenny
reviewed
Mar 14, 2026
Member
capnkenny
left a comment
capnkenny
left a comment
There was a problem hiding this comment.
Got some questions and nits, will continue reviewing in a while
Graphics/Core/include/NovelRT/Graphics/SecondaryCmdListInfo.hpp
Outdated
Show resolved
Hide resolved
This reverts commit 92017de.
This is a workaround until we get the scheduler dependency graph implemented.
…mes around to see if that improves anything.
capnkenny
requested changes
Mar 17, 2026
Member
capnkenny
left a comment
capnkenny
left a comment
There was a problem hiding this comment.
One nit that needs fixing in the README, as well as CI build failures and clang-format need to be addressed first.
| thirdparty_module(TBB | ||
| URL https://github.com/oneapi-src/oneTBB/archive/refs/tags/v2021.5.0.zip | ||
| URL_HASH SHA512=fde7eb56b46fa86b619eb60e587728d19f31639ec06dfd5d7af0dab00ffba38606d7a89dcf050c4cdfa8896560a7424a3431619108f395348dadf60ad6b67a1b | ||
| URL https://github.com/uxlfoundation/oneTBB/archive/refs/tags/v2022.1.0.zip |
Member
There was a problem hiding this comment.
I believe this will need a readme update - as well as the Vulkan 1.4 updates
Removed RegisterDescriptorSetForFrame or whatever its name was, temporarily. Ideally in the future we'd have the GraphicsContext store the semaphore-based caching logic we have now, but in the interest of getting this PR merged we're just implementing it directly.
capnkenny
approved these changes
Mar 17, 2026
Member
capnkenny
left a comment
capnkenny
left a comment
There was a problem hiding this comment.
LGTM - thank you for the hard work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically #622 but based on a different concept. This is mainly just for comparison.